Re: [PATCH] fs/partitions/check.c: add_partition() warning fixes (take 2)

On Mon, 30 Jul 2007 17:47:55 +0800,
Eugene Teo <[email protected]> wrote:

> +err_out_del_link:
> +	sysfs_remove_link(&p->kobj, "subsystem");
> +err_out_del_kobj:
> +	if (!disk->part_uevent_suppress)
> +		kobject_uevent(&p->kobj, KOBJ_REMOVE);
> +	kobject_put(&p->kobj);
> +err_out:
> +	kfree(p);
>  }

No, this is wrong. You need to move the put behind err_out and remove
the kfree. (The release function will take care of p.)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] fs/partitions/check.c: add_partition() warning fixes (take 2)
    • From: Eugene Teo <[email protected]>

• References:
  • [PATCH] fs/partitions/check.c: add_partition() warning fixes (take 2)
    • From: Eugene Teo <[email protected]>

• Prev by Date: Re: [2.6 patch] mm/page_alloc.c: make code static
• Next by Date: Re: ATA scsi driver misbehavior under kdump capture kernel
• Previous by thread: [PATCH] fs/partitions/check.c: add_partition() warning fixes (take 2)
• Next by thread: Re: [PATCH] fs/partitions/check.c: add_partition() warning fixes (take 2)
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]