Re: [GIT PATCH] SCSI bug fixes for 2.6.23-rc1

[Jeff Garzik <jeff@garzik.org>]

James Bottomley wrote:
> On Sun, 2007-07-29 at 21:04 -0400, Jeff Garzik wrote:
> > James Bottomley wrote:
> > > msleep_interruptible -> ssleep is a
> > > change with zero practical impact for this driver,
> > eh, how do you figure?
> >
> > A signal can clearly cause the abort-related functions to delay far 
> > shorter than the driver wishes.
> >
> > The msleep_interruptible() in arcmsr_wait_msgint_ready() probably isn't 
> > fatal -- unless it's there to ensure the hardware isn't pounded -- but 
> > again, a signal can cause a CPU-wasting busy loop that could last for 
> > quite a while (in CPU terms).
>
> I didn't say the usage wasn't a bad example or couldn't cause problems
> in certain cases.  I said "zero practical effect".  This is because the
> two possible threads that enter these routines already have all user
> signals blocked.

Ah!  Understood.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/