Re: [PATCH] drivers/bluetooth/hci_ldisc.c: fix possible NULL dereferences

Hi Marcel,

Marcel Holtmann wrote:
>> Commit 22ad42033b7d2b3d7928fba9f89d1c7f8a3c9581 did not completely fix all 
>> the possible NULL dereferences. Besides hci_uart_close(), we also need to 
>> make sure that hdev is valid before calling hci_{unregister,free}_dev().
> 
> I don't see any issue. Without HCI_UART_PROTO_SET, the hdev will never
> be registered. So no need to protect it twice.

Correct me if I am wrong. HCI_UART_PROTO_SET bit is only set if hci_uart_tty_ioctl()
is called with HCIUARTSETPROTO. Is it possible for the HCI device to be registered
and then unregistered without setting the HCI_UART_PROTO_SET bit in hdev->flags?

Thanks,
Eugene
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] drivers/bluetooth/hci_ldisc.c: fix possible NULL dereferences
    • From: Marcel Holtmann <[email protected]>

• References:
  • [PATCH] drivers/bluetooth/hci_ldisc.c: fix possible NULL dereferences
    • From: Eugene Teo <[email protected]>
  • Re: [PATCH] drivers/bluetooth/hci_ldisc.c: fix possible NULL dereferences
    • From: Marcel Holtmann <[email protected]>

• Prev by Date: Re: [PATCH] sh64: arch/sh64/kernel/signal.h - duplicate include removal
• Next by Date: Re: [PATCH] powerpc: clean out a bunch of duplicate includes
• Previous by thread: Re: [PATCH] drivers/bluetooth/hci_ldisc.c: fix possible NULL dereferences
• Next by thread: Re: [PATCH] drivers/bluetooth/hci_ldisc.c: fix possible NULL dereferences
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]