Re: [PATCH 2/3] core_pattern: allow passing of arguments to user mode helper when core_pattern is a pipe

[Eugene Teo <eteo@redhat.com>]

Neil Horman wrote:
[...]
> +			/* core limit size */
> +			case 'c':
> +				rc = snprintf(out_ptr, out_end - out_ptr,
> +					      "%lu", current->signal->rlim[RLIMIT_CORE].rlim_cur); 

Trailing space.

[...]
> - 		if(call_usermodehelper_pipe(corename+1, NULL, NULL, &file)) {
> + 		if(call_usermodehelper_pipe(corename+1, helper_argv, NULL, &file)) {
   ^^^^^^^^^^^^^

Use tabs, and a missing space after '('.

Eugene
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/