Re: [PATCH] ia64: fix a few section mismatch warnings

On Fri, Jul 27, 2007 at 03:32:13PM -0700, Luck, Tony wrote:
> -		mca_data = alloc_bootmem(sizeof(struct ia64_mca_cpu)
> -					 * NR_CPUS + KERNEL_STACK_SIZE);
> +		mca_data = mca_bootmem(NR_CPUS + KERNEL_STACK_SIZE);
> 
> Oops.  You moved the multiply by sizeof(struct ia64_mca_cpu) up into
> the mca_bootmem() function to make it very specific to this use. But
> mutiply has higher precedence than addition.

Oh crap - good catch.
Shall I resubmit a corrected patch?

	Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • RE: [PATCH] ia64: fix a few section mismatch warnings
    • From: "Luck, Tony" <[email protected]>

• References:
  • Re: [PATCH] ia64: fix a few section mismatch warnings
    • From: Sam Ravnborg <[email protected]>
  • RE: [PATCH] ia64: fix a few section mismatch warnings
    • From: "Luck, Tony" <[email protected]>

• Prev by Date: [PATCH] flush icache before set_pte() take 5. [2/2] sync icache dcache for ia64
• Next by Date: Re: mm/sparse.c:482: error: implicit declaration of function ‘sparse_early_usemap_alloc’
• Previous by thread: RE: [PATCH] ia64: fix a few section mismatch warnings
• Next by thread: RE: [PATCH] ia64: fix a few section mismatch warnings
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]