Re: [PATCH 2/3] core_pattern: allow passing of arguments to user mode helper when core_pattern is a pipe

Neil Horman wrote:
> +	int helper_argc = 0;
>   
> +		helper_argv = argv_split(GFP_KERNEL, corename+1, &helper_argc);
>   

Hm, I suspect most users of argv_split don't really care about argc, so
it would useful to change argv_split to take NULL as the argc pointer,
rather than declare a bunch of unused variables.  Interested in throwing
a patch together?

    J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 2/3] core_pattern: allow passing of arguments to user mode helper when core_pattern is a pipe
    • From: Neil Horman <[email protected]>

• References:
  • [PATCH 2/3] core_pattern: allow passing of arguments to user mode helper when core_pattern is a pipe
    • From: Neil Horman <[email protected]>

• Prev by Date: [1/3] 2.6.23-rc1: known regressions v2
• Next by Date: Re: [2/3] 2.6.23-rc1: known regressions v2
• Previous by thread: [PATCH 2/3] core_pattern: allow passing of arguments to user mode helper when core_pattern is a pipe
• Next by thread: Re: [PATCH 2/3] core_pattern: allow passing of arguments to user mode helper when core_pattern is a pipe
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]