Re: [PATCH][dccp] Fix memory leak and clean up style - dccp_feat_empty_confirm()

On 7/27/07, Jesper Juhl <[email protected]> wrote:

Greetings,

There's a memory leak in net/dccp/feat.c::dccp_feat_empty_confirm().
If we hit the 'default:' case of the 'switch' statement, then we
return without freeing 'opt', thus leaking 'struct dccp_opt_pend'
bytes.
The leak is fixed easily enough by adding a kfree(opt); before the
return statement.
The patch also changes the layout of the 'switch' to be more in line
with CodingStyle.

Patch has been compile tested.

Please consider merging.


Signed-off-by: Jesper Juhl <[email protected]>

Signed-off-by: Ian McDonald <[email protected]>
--
Web1: http://wand.net.nz/~iam4/
Web2: http://www.jandi.co.nz
Blog: http://iansblog.jandi.co.nz
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH][dccp] Fix memory leak and clean up style - dccp_feat_empty_confirm()
    • From: Jesper Juhl <[email protected]>

• Prev by Date: Re: [PATCH] usbhid: add ASUS LCM to the blacklist
• Next by Date: Re: IRQF_DISABLED problem
• Previous by thread: [PATCH][dccp] Fix memory leak and clean up style - dccp_feat_empty_confirm()
• Next by thread: Linux 2.4.35 released
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]