pte_offset_map for ppc assumes HIGHPTE

hello,
The implementation of pte_offset_map() for ppc assumes that PTEs are
kept in highmem (CONFIG_HIGHPTE). There is only one implmentation of
pte_offset_map() as follows (include/asm-ppc/pgtable.h):

#define pte_offset_map(dir, addr)               \
        ((pte_t *) kmap_atomic(pmd_page(*(dir)), KM_PTE0) + pte_index(addr))

Shouldn't this be made conditional according to CONFIG_HIGHPTE is
defined or not (as implemented in include/asm-i386/pgtable.h) ?

the same goes for pte_offset_map_nested and the corresponding unmap functions.

thanks,
Satya Popuri
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: pte_offset_map for ppc assumes HIGHPTE
    • From: Andreas Schwab <[email protected]>
  • Re: pte_offset_map for ppc assumes HIGHPTE
    • From: Benjamin Herrenschmidt <[email protected]>

• Prev by Date: [PATCH -mm] dma: INTEL_IOATDMA build fix
• Next by Date: Re: Problems with timerfd()
• Previous by thread: [PATCH -mm] dma: INTEL_IOATDMA build fix
• Next by thread: Re: pte_offset_map for ppc assumes HIGHPTE
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]