Re: 2.6.23-rc1: BUG_ON in kmap_atomic_prot()

On Tue, 24 Jul 2007, Adrian Bunk wrote:
> 
> buffered_rmqueue() and prep_new_page() are static functions with only 
> one caller each, and for the normal non-debug case it's a really nice 
> optimization to have them inlined automatically.

I'm not at all sure I agree.

Inlining big functions doesn't actually tend to generally generate any 
better code, so if gcc's logic is "single callsite - always inline", then 
that logic is likely not right.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: commit 7e92b4fc34 - x86, serial: convert legacy COM ports to platform devices - broke my serial console
    • From: "H. Peter Anvin" <[email protected]>
  • Re: 2.6.23-rc1: BUG_ON in kmap_atomic_prot()
    • From: Andrew Morton <[email protected]>

• References:
  • Linus 2.6.23-rc1
    • From: Linus Torvalds <[email protected]>
  • 2.6.23-rc1: BUG_ON in kmap_atomic_prot()
    • From: Alexey Dobriyan <[email protected]>
  • Re: 2.6.23-rc1: BUG_ON in kmap_atomic_prot()
    • From: Alexey Dobriyan <[email protected]>
  • Re: 2.6.23-rc1: BUG_ON in kmap_atomic_prot()
    • From: Andrew Morton <[email protected]>
  • Re: 2.6.23-rc1: BUG_ON in kmap_atomic_prot()
    • From: Alexey Dobriyan <[email protected]>
  • Re: 2.6.23-rc1: BUG_ON in kmap_atomic_prot()
    • From: Alexey Dobriyan <[email protected]>
  • Re: 2.6.23-rc1: BUG_ON in kmap_atomic_prot()
    • From: Andrew Morton <[email protected]>
  • Re: 2.6.23-rc1: BUG_ON in kmap_atomic_prot()
    • From: Linus Torvalds <[email protected]>
  • Re: 2.6.23-rc1: BUG_ON in kmap_atomic_prot()
    • From: Adrian Bunk <[email protected]>

• Prev by Date: [PATCH 05/11] mv64x60_wdt: Fix WDIOC_GETTIMEOUT return value
• Next by Date: [PATCH 06/11] mv64x60_wdt: Support for WDIOC_SETTIMEOUT ioctl
• Previous by thread: Re: 2.6.23-rc1: BUG_ON in kmap_atomic_prot()
• Next by thread: Re: 2.6.23-rc1: BUG_ON in kmap_atomic_prot()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]