Re: [PATCH] add __GFP_ZERO to GFP_LEVEL_MASK

On Mon, 23 Jul 2007, Peter Zijlstra wrote:

> ---
> Daniel recently spotted that __GFP_ZERO is not (and has never been)
> part of GFP_LEVEL_MASK. I could not find a reason for this in the
> original patch: 3977971c7f09ce08ed1b8d7a67b2098eb732e4cd in the -bk
> tree.
> 
> This of course is in stark contradiction with the comment accompanying
> GFP_LEVEL_MASK.

NACK.

The effect that this patch will have is that __GFP_ZERO is passed through 
to the page allocator which will needlessly zero pages. GFP_LEVEL_MASK is 
used to filter out the flags that are to be passed to the page allocator. 
__GFP_ZERO is not passed on but handled by the slab allocators.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] add __GFP_ZERO to GFP_LEVEL_MASK
    • From: Peter Zijlstra <[email protected]>

• References:
  • [PATCH] add __GFP_ZERP to GFP_LEVEL_MASK
    • From: Peter Zijlstra <[email protected]>
  • Re: [PATCH] add __GFP_ZERP to GFP_LEVEL_MASK
    • From: [email protected] (Mel Gorman)
  • Re: [PATCH] add __GFP_ZERO to GFP_LEVEL_MASK
    • From: Peter Zijlstra <[email protected]>

• Prev by Date: Re: __unsafe() usage
• Next by Date: Re: [patch 4/9] topology: remove topology_dev_map
• Previous by thread: Re: [PATCH] add __GFP_ZERO to GFP_LEVEL_MASK
• Next by thread: Re: [PATCH] add __GFP_ZERO to GFP_LEVEL_MASK
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]