On Monday, 23 July 2007 20:38, Agarwal, Lomesh wrote:
> The other problem I am facing that read from socket returns with ENODATA
> when resuming. any ideas?
It's of similar kind: the system call checks signal_pending(current) and exit
with an error if that's true.
Well, I'm afraid we can't place try_to_freeze() in every system call that
does something like that ...
Greetings,
Rafael
> -----Original Message-----
> From: Rafael J. Wysocki [mailto:[email protected]]
> Sent: Friday, July 20, 2007 3:10 PM
> To: Agarwal, Lomesh
> Cc: [email protected]; [email protected]
> Subject: Re: which signal is sent to freeze process?
>
> On Friday, 20 July 2007 20:07, Agarwal, Lomesh wrote:
> > Can you suggest a way I can debug the issue why I am getting EINTR
> error
> > for system calls in resuming? What else can cause the system call
> > failure with EINTR?
>
> Well, I think I know what the problem is. do_poll checks
> signal_pending(current) and breaks when it's set, but that may be caused
> by the freezer.
>
> You may try the patch below (untested) and see if that helps.
>
> Greetings,
> Rafael
>
>
> ---
> fs/select.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> Index: linux-2.6.22-rc6-mm1/fs/select.c
> ===================================================================
> --- linux-2.6.22-rc6-mm1.orig/fs/select.c
> +++ linux-2.6.22-rc6-mm1/fs/select.c
> @@ -23,6 +23,7 @@
> #include <linux/file.h>
> #include <linux/fs.h>
> #include <linux/rcupdate.h>
> +#include <linux/freezer.h>
>
> #include <asm/uaccess.h>
>
> @@ -593,6 +594,8 @@ static int do_poll(unsigned int nfds, s
> struct poll_list *walk;
> long __timeout;
>
> + try_to_freeze();
> +
> set_current_state(TASK_INTERRUPTIBLE);
> for (walk = list; walk != NULL; walk = walk->next) {
> struct pollfd * pfd, * pfd_end;
> @@ -618,7 +621,8 @@ static int do_poll(unsigned int nfds, s
> * a poll_table to them on the next loop iteration.
> */
> pt = NULL;
> - if (count || !*timeout || signal_pending(current))
> + if (count || !*timeout ||
> + (signal_pending(current) && !freezing(current)))
> break;
> count = wait->error;
> if (count)
>
>
--
"Premature optimization is the root of all evil." - Donald Knuth
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
