Re: [PATCH] release quicklist before free_page

On Mon, 2007-07-23 at 20:23 +0200, Ingo Molnar wrote:
> 
> how about: "if you've got some time then please also add a few comments, 
> because the code was quite non-obvious to me and I misunderstood it when 
> I tried to fix it. Thanks."

Not exactly what I was thinking of .. More like,

"LOCKING NOTE: This code uses the fact that get_cpu_var disables
preemption to maintain cpu affinity during the call to free_page()
otherwise it might free pages on another cpu."

(btw, your comment above comes off very snide, which I don't appreciate.
I haven't done anything that remotely warrants that.)

Daniel

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] release quicklist before free_page
    • From: Ingo Molnar <[email protected]>

• References:
  • [PATCH] release quicklist before free_page
    • From: Daniel Walker <[email protected]>
  • Re: [PATCH] release quicklist before free_page
    • From: Peter Zijlstra <[email protected]>
  • Re: [PATCH] release quicklist before free_page
    • From: Daniel Walker <[email protected]>
  • Re: [PATCH] release quicklist before free_page
    • From: Ingo Molnar <[email protected]>

• Prev by Date: Re: [PATCH] add __GFP_ZERP to GFP_LEVEL_MASK
• Next by Date: RE: which signal is sent to freeze process?
• Previous by thread: Re: [PATCH] release quicklist before free_page
• Next by thread: Re: [PATCH] release quicklist before free_page
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]