Re: [PATCH] fix broken handling of port=... in NFS option parsing

ACK.

Al Viro wrote:

	Obviously broken on little-endian; fortunately, the option is
not frequently used...

Signed-off-by: Al Viro <[email protected]>
---
diff --git a/fs/nfs/super.c b/fs/nfs/super.c
index b34b7a7..b2a851c 100644
--- a/fs/nfs/super.c
+++ b/fs/nfs/super.c
@@ -732,7 +732,7 @@ static int nfs_parse_mount_options(char *raw,
 				return 0;
 			if (option < 0 || option > 65535)
 				return 0;
-			mnt->nfs_server.address.sin_port = htonl(option);
+			mnt->nfs_server.address.sin_port = htons(option);
 			break;
 		case Opt_rsize:
 			if (match_int(args, &mnt->rsize))

begin:vcard
fn:Chuck Lever
n:Lever;Chuck
org:Oracle Corporation;Corporate Architecture: Linux Projects Group
adr:;;1015 Granger Avenue;Ann Arbor;MI;48104;USA
title:Principal Member of Staff
tel;work:+1 248 614 5091
x-mozilla-html:FALSE
version:2.1
end:vcard

---

• References:
  • [PATCH] fix broken handling of port=... in NFS option parsing
    • From: Al Viro <[email protected]>

• Prev by Date: RE: drivers/dma/ioatdma.c - address of '__this_module' will always evaluate as 'true' , warning
• Next by Date: Re: Determine version of kernel that produced vmcore
• Previous by thread: Re: [PATCH] fix broken handling of port=... in NFS option parsing
• Next by thread: Pata support for IDE Controller 82801G ICH7 in Linux 2.6.22
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]