On Wednesday 20 June 2007, H. Peter Anvin wrote: > Andi Kleen wrote: > >> asm-i386/msr.h should not be exported to userspace at all, it contains > >> nothing but kernel-internal helpers. > > > > Actually rdtsc and rdtscll and potentially rdpmc which is in there can be > > very useful in user space if you know what you're doing. Unfortunately a > > lot of its users don't, but not having the include probably won't stop > > them either. > > More likely, people will just re-implement them incorrectly. > > However, the rdtsc() definition in the kernel is weird (and removable, I > think there are no more users -- I have it removed in my MSR driver > rewrite tree which I need to get off my arse and push.) Most users > would expect the rdtscll() functionality with the rdtsc() name. does that mean you'll also take care of cleaning up msr.h ? or do i need to post another patch ? -mike
Attachment:
signature.asc
Description: This is a digitally signed message part.
- Follow-Ups:
- Re: [patch] use __asm__ and __volatile__ in asm-x86_64/msr.h
- From: "H. Peter Anvin" <[email protected]>
- Re: [patch] use __asm__ and __volatile__ in asm-x86_64/msr.h
- Prev by Date: Re: voyager_{thread,cat}.c compile warnings
- Next by Date: rtc-ds1307.c: array overrun
- Previous by thread: 2.6.23 regression: lpfc_sli.c: off-by-10
- Next by thread: Re: [patch] use __asm__ and __volatile__ in asm-x86_64/msr.h
- Index(es):
 |