Re: diffutils: C labels misdetected as functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Simon Arlott <[email protected]> writes:

> The patch below stops diffutils treating C labels starting in column 1 as function names.

That patch alone wouldn't suffice, since -p is documented as implying
-F '^[[:alpha:]$_]'.  If the behavior changes, we'd also have to
change the documentation to match.

I'm not sure the change is a good idea.  It would complicate the
documentation and therefore the user interface, without that much
benefit.  And it wouldn't suffice in general, since it would still
mishandle labels followed by comments or by white space.

Also, for long C functions some people might rather see a top-level
(unindented) label highlighted than the function name highlighted, so
they might prefer the current behavior.

Anyway, to work around your problem without changing "diff", you can
use "diff -u -F '^[[:alpha:]$_](|.*[^:])$'" instead of "diff -u -p".
Or you can put a single space before the labels in question: they'll
still stand out plenty.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux