Re: NFS mount gives ENETDOWN in -git15

[Trond Myklebust <trond.myklebust@fys.uio.no>]

On Sat, 2007-07-21 at 15:31 +0200, Andi Kleen wrote:
> I tried to mount another nfs mount on a system running with nfsroot.
> But I get
> 
> # mount basil:/home /basil/home/
> mount: Network is down
> 
> The network is not down of course, the system is happily running with nfs root from that
> server. Userland is older SUSE 10.0

Does Al's patch help in any way?

Cheers
  Trond

--- Begin Message ---

• To: Linus Torvalds <torvalds@linux-foundation.org>
• Subject: [PATCH] fix broken handling of port=... in NFS option parsing
• From: Al Viro <viro@ftp.linux.org.uk>
• Date: Sun, 22 Jul 2007 10:59:06 +0100
• Cc: Chuck Lever <chuck.lever@oracle.com>, Trond Myklebust <Trond.Myklebust@netapp.com>, linux-kernel@vger.kernel.org
• User-agent: Mutt/1.4.1i

	Obviously broken on little-endian; fortunately, the option is
not frequently used...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
diff --git a/fs/nfs/super.c b/fs/nfs/super.c
index b34b7a7..b2a851c 100644
--- a/fs/nfs/super.c
+++ b/fs/nfs/super.c
@@ -732,7 +732,7 @@ static int nfs_parse_mount_options(char *raw,
 				return 0;
 			if (option < 0 || option > 65535)
 				return 0;
-			mnt->nfs_server.address.sin_port = htonl(option);
+			mnt->nfs_server.address.sin_port = htons(option);
 			break;
 		case Opt_rsize:
 			if (match_int(args, &mnt->rsize))

--- End Message ---