Re: [PATCH] x86: Create clflush() inline, remove hardcoded wbinvd

On Fri, Jul 20, 2007 at 02:33:46PM -0700, H. Peter Anvin wrote:
> Andi Kleen wrote:
> > On Fri, Jul 20, 2007 at 02:19:58PM -0700, H. Peter Anvin wrote:
> >> Create an inline function for clflush(), with the proper arguments,
> >> and use it instead of hard-coding the instruction.
> >>
> >> This also removes one instance of hard-coded wbinvd, based on a patch
> >> by Bauder de Oliveira Costa.
> > 
> > I don't see much sense in it. CLFLUSH is not priviledged, paravirt
> > doesn't need to change and this adds just an unnecessary layer of abstraction.
> 
> The main reason is that everyone seems to invoke it either incorrectly

Where is it incorrect? 

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] x86: Create clflush() inline, remove hardcoded wbinvd
    • From: "H. Peter Anvin" <[email protected]>

• References:
  • [PATCH] Use wbinvd() macro instead of raw inline assembly in .c files
    • From: Glauber de Oliveira Costa <[email protected]>
  • [PATCH] x86: Create clflush() inline, remove hardcoded wbinvd
    • From: "H. Peter Anvin" <[email protected]>
  • Re: [PATCH] x86: Create clflush() inline, remove hardcoded wbinvd
    • From: Andi Kleen <[email protected]>
  • Re: [PATCH] x86: Create clflush() inline, remove hardcoded wbinvd
    • From: "H. Peter Anvin" <[email protected]>

• Prev by Date: Re: [PATCH 3/3] readahead: scale max readahead size depending on memory size
• Next by Date: Re: [PATCH] x86_64 vDSO: install unstripped copies on disk
• Previous by thread: Re: [PATCH] x86: Create clflush() inline, remove hardcoded wbinvd
• Next by thread: Re: [PATCH] x86: Create clflush() inline, remove hardcoded wbinvd
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]