Re: [DRIVER SUBMISSION] DRBD wants to go mainline

> there is just one logical piece, the drbd module...
> it is all in its own subdirectory.

For review purposes the split is often file based.
Something along the lines of:

Makefile + Kconfig
include/linux/drdb*   <= why 5 files for one module?
drdb_main.c
drdb_req.{c+h}
etc..

So essentially smaller pieces that can be revied but when ready for inclusion
it should go in as _one_ commit to avoid breaking bisect.

But please finish off all the CodingStyle issue before submission so the
review can concentrate on the actual content.

Quickly browsing drdb_int.h shows that there are a few issues yet to sort out.
typedef usage, funny macros, volatile etc.

	Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [DRIVER SUBMISSION] DRBD wants to go mainline
    • From: "Pekka Enberg" <[email protected]>

• References:
  • [DRIVER SUBMISSION] DRBD wants to go mainline
    • From: Lars Ellenberg <[email protected]>
  • Re: [DRIVER SUBMISSION] DRBD wants to go mainline
    • From: Andi Kleen <[email protected]>
  • Re: [DRIVER SUBMISSION] DRBD wants to go mainline
    • From: Lars Ellenberg <[email protected]>

• Prev by Date: Re: [PATCH 3/3] readahead: scale max readahead size depending on memory size
• Next by Date: Re: [linux-usb-devel] PXA27x UDC driver GIT repository
• Previous by thread: Re: [DRIVER SUBMISSION] DRBD wants to go mainline
• Next by thread: Re: [DRIVER SUBMISSION] DRBD wants to go mainline
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]