Re: [PATCH] x86_64: use apic core id bits for core nums

On 7/21/07, Andi Kleen <[email protected]> wrote:

On Saturday 21 July 2007 09:56:15 Yinghai Lu wrote:
> please check my version, we should use core id bits instead.
>
> it should replace
> [PATCH for review] [37/48] x86_64: make k8topology multi-core aware

Yes, you're right the patch is not good. It should probably use
information from the regular CPU setup code, not touch cpuid
directly

need move some code into early_identify_cpu from identify_cpu in
arch/x86_64/kernel/setup.c
then could use that bits in bsp cpu info.

BTW:
it seems for BSP only early_identify_cpu is called, and identify_cpu
is only use in smp_callin for AP. Do i miss sth.

YH
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] x86_64: use apic core id bits for core nums
    • From: Andi Kleen <[email protected]>

• References:
  • [PATCH] x86_64: use apic core id bits for core nums
    • From: "Yinghai Lu" <[email protected]>
  • Re: [PATCH] x86_64: use apic core id bits for core nums
    • From: Andi Kleen <[email protected]>

• Prev by Date: [PATCH] drivers/char/hpet.c: integer constant is too large for "long" type
• Next by Date: Re: [PATCH] Fix DMA on Dreamcast
• Previous by thread: Re: [PATCH] x86_64: use apic core id bits for core nums
• Next by thread: Re: [PATCH] x86_64: use apic core id bits for core nums
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]