On Fri, 20 Jul 2007 18:02:57 -0700 Greg KH <gregkh@suse.de> wrote: > --- a/kernel/params.c > +++ b/kernel/params.c > @@ -567,7 +567,11 @@ static void __init kernel_param_sysfs_se > kobject_set_name(&mk->kobj, name); > kobject_init(&mk->kobj); > ret = kobject_add(&mk->kobj); > - BUG_ON(ret < 0); > + if (ret) { > + printk(KERN_ERR "module '%s' failed to be added to sysfs, " > + "the system will be unstable now.\n", name); > + return; > + } It would be nice to print the value of `ret' too. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [broken-out-2007-07-20-00-22] kernel bug at kernel/params:570
- From: Greg KH <gregkh@suse.de>
- Re: [broken-out-2007-07-20-00-22] kernel bug at kernel/params:570
- References:
- [broken-out-2007-07-20-00-22] kernel bug at kernel/params:570
- From: "Michal Piotrowski" <michal.k.k.piotrowski@gmail.com>
- Re: [broken-out-2007-07-20-00-22] kernel bug at kernel/params:570
- From: Greg KH <gregkh@suse.de>
- Re: [broken-out-2007-07-20-00-22] kernel bug at kernel/params:570
- From: Andrew Morton <akpm@linux-foundation.org>
- Re: [broken-out-2007-07-20-00-22] kernel bug at kernel/params:570
- From: Greg KH <gregkh@suse.de>
- Re: [broken-out-2007-07-20-00-22] kernel bug at kernel/params:570
- From: "Satyam Sharma" <satyam.sharma@gmail.com>
- Re: [broken-out-2007-07-20-00-22] kernel bug at kernel/params:570
- From: "Satyam Sharma" <satyam.sharma@gmail.com>
- Re: [broken-out-2007-07-20-00-22] kernel bug at kernel/params:570
- From: "Michal Piotrowski" <michal.k.k.piotrowski@gmail.com>
- Re: [broken-out-2007-07-20-00-22] kernel bug at kernel/params:570
- From: Greg KH <gregkh@suse.de>
- [broken-out-2007-07-20-00-22] kernel bug at kernel/params:570
- Prev by Date: Re: [PATCH] AFS: Fix file locking
- Next by Date: Re: [broken-out-2007-07-20-00-22] kernel bug at kernel/params:570
- Previous by thread: Re: [broken-out-2007-07-20-00-22] kernel bug at kernel/params:570
- Next by thread: Re: [broken-out-2007-07-20-00-22] kernel bug at kernel/params:570
- Index(es):
![]() |