Re: [PATCH 1/6] compacting file_ra_state

[Linus Torvalds <torvalds@linux-foundation.org>]

On Fri, 20 Jul 2007, Fengguang Wu wrote:

> On Fri, Jul 20, 2007 at 01:34:42PM +0200, Andi Kleen wrote:
> > 
> > This would add a new limit to 64bit architectures.  Surely keeping
> > start at pgoff_t will not be a big issue? The other fields can be
> > 32bit.
> 
> Yeah, it counts for about 4MB memory for 1M opened files.

I'd suggest keeping "start" as pgoff_t, and doing what Peter Zijlstra 
suggested about prev_offset / prev_index and turning that combination into 
a "loff_t". The latter will cause some more 64-bit operations, but by now 
I think we can start thinking of 64 bits as the norm, and it will be more 
logical, methinks.

Then, when/if we add a config option to turn pgoff_t into a 32-bit entry 
for us normal people who think that 16TB is plenty (and would rather have 
smaller and faster harddisks than go beyond it), that will also solve the 
"start" issue.

Does that sound like a plan?

So I'm going to ignore the current series in the hopes that we'll have a 
new one soon enough.

			Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/