Re: [PATCH] procfs fixes for inotify/dnotify

[Alexey Dobriyan <adobriyan@gmail.com>]

On Thu, Jul 19, 2007 at 03:03:55PM -0700, Andrew Morton wrote:
> 	http://bugzilla.kernel.org/show_bug.cgi?id=8782

[fsnotify and /proc]

> > --- linux-2.6.15/fs/proc/base.c
> > +++ linux-2.6.15.4/fs/proc/base.c
> > @@ -1945,6 +1945,7 @@
> >  	if(proc_dentry != NULL) {
> >  		shrink_dcache_parent(proc_dentry);
> >  		dput(proc_dentry);
> > +		fsnotify_nameremove (proc_dentry, 1);
> >  	}
> 
> I wonder if this is racy - after the dput() we might no longer have a
> reference?

It is indeed racy. dput() => kill_it: => d_kill() => d_free() =>
__d_free() eventually. *boom*

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/