Re: [PATCH] Memory leak in tpm_ascii_bios_measurements_open() fix.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Yinghai Lu" <[email protected]>
Subject: Re: [PATCH] Memory leak in tpm_ascii_bios_measurements_open() fix.
From: "Satyam Sharma" <[email protected]>
Date: Fri, 20 Jul 2007 10:06:13 +0530
Cc: "Reiner Sailer" <[email protected]>, "Jesper Juhl" <[email protected]>, [email protected], "Linux Kernel Mailing List" <[email protected]>, "Seiji Munetoh" <[email protected]>, "Reiner Sailer" <[email protected]>, [email protected]
In-reply-to: <[email protected]>
References: <[email protected]> <[email protected]> <[email protected]>
Sender: [email protected]

On 7/20/07, Yinghai Lu <[email protected]> wrote:

out_free:
   kfree(log->bios_event_log);
   kfree(log);
out:
   return err;

could kill one extra goto.


Such constructs disallow the success path from falling through
to the same "return err;" (with err = 0 for success obviously)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- Re: [PATCH] Memory leak in tpm_ascii_bios_measurements_open() fix.
  - From: Reiner Sailer <[email protected]>
- Re: [PATCH] Memory leak in tpm_ascii_bios_measurements_open() fix.
  - From: "Satyam Sharma" <[email protected]>
- Re: [PATCH] Memory leak in tpm_ascii_bios_measurements_open() fix.
  - From: "Yinghai Lu" <[email protected]>

Prev by Date: Re: [git pull] More input updates for post-2.6.22
Next by Date: Re: Hibernation considerations
Previous by thread: Re: [PATCH] Memory leak in tpm_ascii_bios_measurements_open() fix.
Next by thread: [GIT PATCH] UIO patches for 2.6.22
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]

Powered by Linux