[PATCH] [scsi] lpfc: potential leak in lpfc_sli_hbqbuf_fill_hbqs

If lpfc_hbq_alloc() fails, an hbq_buffer is leaked. Found by Coverity (1775).

Signed-off-by: Florin Malita <[email protected]>
---

drivers/scsi/lpfc/lpfc_sli.c |    4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
index f4d5a6b..fe16b0c 100644
--- a/drivers/scsi/lpfc/lpfc_sli.c
+++ b/drivers/scsi/lpfc/lpfc_sli.c
@@ -622,8 +622,10 @@ lpfc_sli_hbqbuf_fill_hbqs(struct lpfc_hba *phba, uint32_t hbqno, uint32_t count)
			return 1;
		hbq_buffer->dbuf.virt = lpfc_hbq_alloc(phba, MEM_PRI,
							&hbq_buffer->dbuf.phys);
-		if (hbq_buffer->dbuf.virt == NULL)
+		if (hbq_buffer->dbuf.virt == NULL) {
+			kfree(hbq_buffer);
			return 1;
+		}
		hbq_buffer->tag = (i | (hbqno << 16));
		lpfc_sli_hbq_to_firmware(phba, hbqno, hbq_buffer);
		lpfc_hbq_defs[hbqno]->buffer_count++;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] [scsi] lpfc: potential leak in lpfc_sli_hbqbuf_fill_hbqs
    • From: James Smart <[email protected]>

• Prev by Date: Re: Someone ( bsg merge ? ) broke {sd,hd}parm on current git
• Next by Date: Re: [patch] revert: [NET]: Fix races in net_rx_action vs netpoll
• Previous by thread: [PATCH] powerpc: Allow smp_call_function_single() to current cpu
• Next by thread: Re: [PATCH] [scsi] lpfc: potential leak in lpfc_sli_hbqbuf_fill_hbqs
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]