[PATCH] [19/58] x86_64: Don't use softirq save locks in smp_call_function

It is not fully softirq safe anyways.

Can't do a WARN_ON unfortunately because it could trigger in the 
panic case.

Signed-off-by: Andi Kleen <[email protected]>

---
 arch/x86_64/kernel/smp.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux/arch/x86_64/kernel/smp.c
===================================================================
--- linux.orig/arch/x86_64/kernel/smp.c
+++ linux/arch/x86_64/kernel/smp.c
@@ -386,9 +386,9 @@ int smp_call_function_single (int cpu, v
 		return 0;
 	}
 
-	spin_lock_bh(&call_lock);
+	spin_lock(&call_lock);
 	__smp_call_function_single(cpu, func, info, nonatomic, wait);
-	spin_unlock_bh(&call_lock);
+	spin_unlock(&call_lock);
 	put_cpu();
 	return 0;
 }
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] [19/58] x86_64: Don't use softirq save locks in smp_call_function
    • From: "Satyam Sharma" <[email protected]>

• References:
  • [PATCH] [0/58] First batch of x86 patches for .23
    • From: Andi Kleen <[email protected]>

• Prev by Date: [PATCH] [18/58] x86_64: remove extra extern declaring about dmi_ioremap
• Next by Date: [PATCH] [20/58] x86: Always probe the NMI watchdog
• Previous by thread: [PATCH] [18/58] x86_64: remove extra extern declaring about dmi_ioremap
• Next by thread: Re: [PATCH] [19/58] x86_64: Don't use softirq save locks in smp_call_function
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]