On Thu, 19 Jul 2007 00:48:03 +0200
Jesper Juhl <[email protected]> wrote:
> Hello,
>
> In drivers/acpi/events/evrgnini.c::acpi_ev_pci_config_region_setup()
> there is a memory leak.
> We may return at "if (!pci_device_node)" without freeing storage
> previously allocated and assigned to 'pci_id'.
> This patch fixes the leak by freeing the allocated storage in this
> case.
>
> Compile tested only...
>
>
> Signed-off-by: Jesper Juhl <[email protected]>
> ---
>
> drivers/acpi/events/evrgnini.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/acpi/events/evrgnini.c b/drivers/acpi/events/evrgnini.c
> index 400d90f..10f378b 100644
> --- a/drivers/acpi/events/evrgnini.c
> +++ b/drivers/acpi/events/evrgnini.c
> @@ -284,6 +284,7 @@ acpi_ev_pci_config_region_setup(acpi_handle handle,
> }
>
> if (!pci_device_node) {
> + kfree(pci_id);
> return_ACPI_STATUS(AE_AML_OPERAND_TYPE);
> }
>
We're supposed to use the attractive ACPI_FREE() here. I'll make that
change.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
