Re: [PATCH] appletouch powersaving - please apply for 2.6.23-rc1

Hi,

Good stuff :)

> +	int                     idlecount;      /* number of empty packets */

should probably use tabs here.

> +	size = usb_control_msg(udev, usb_sndctrlpipe(udev, 0),
> +			       ATP_GEYSER3_MODE_WRITE_REQUEST_ID,
> +			       USB_DIR_OUT | USB_TYPE_CLASS | USB_RECIP_INTERFACE,
> +			       ATP_GEYSER3_MODE_REQUEST_VALUE,
> +			       ATP_GEYSER3_MODE_REQUEST_INDEX, &data, 8, 5000);
> +	<eol>

trailing whitespace.

 
> +	input_report_key(dev->input, BTN_LEFT, dev->data[dev->datalen-1] & 1);
> +


> @@ -449,10 +511,19 @@ static void atp_complete(struct urb* urb)
>  
>  		/* reset the accumulator on release */
>  		memset(dev->xy_acc, 0, sizeof(dev->xy_acc));
> -	}
>  
> -	input_report_key(dev->input, BTN_LEFT,
> -			 !!dev->data[dev->datalen - 1]);

Any hint as to why you move this? The different test, yes, ok, you
explained that, but moving it?

johannes

Attachment: signature.asc
Description: This is a digitally signed message part

---

• Follow-Ups:
  • Re: [PATCH] appletouch powersaving - please apply for 2.6.23-rc1
    • From: Soeren Sonnenburg <[email protected]>

• References:
  • [PATCH] appletouch powersaving - please apply for 2.6.23-rc1
    • From: Soeren Sonnenburg <[email protected]>

• Prev by Date: Re: [PATCH 2/3] leds-clevo-mail: hw accelerated LED blink extension
• Next by Date: Re: [PATCH] posix-timer: fix deletion race
• Previous by thread: [PATCH] appletouch powersaving - please apply for 2.6.23-rc1
• Next by thread: Re: [PATCH] appletouch powersaving - please apply for 2.6.23-rc1
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]