On Monday 16 July 2007, Geert Uytterhoeven wrote: > On Sat, 14 Jul 2007, Mike Frysinger wrote: > > Pretty much everyone uses "__attribute__" or "attribute", no one > > uses "__attribute". This patch tweaks the three places in asm-powerpc > > where this comes up. While only asm-powerpc/types.h is interesting (for > > userspace), I did asm-powerpc/processor.h as well for consistency. > > > > Signed-off-by: Mike Frysinger <[email protected]> > > --- > > diff --git a/include/asm-powerpc/processor.h > > b/include/asm-powerpc/processor.h index d947b16..2ce6ea6 100644 > > --- a/include/asm-powerpc/processor.h > > +++ b/include/asm-powerpc/processor.h > > @@ -153,9 +153,9 @@ struct thread_struct { > > unsigned long dabr; /* Data address breakpoint register */ > > #ifdef CONFIG_ALTIVEC > > /* Complete AltiVec register set */ > > - vector128 vr[32] __attribute((aligned(16))); > > + vector128 vr[32] __attribute__((aligned(16))); > > If the code is not exported to userspace (and thus not subject to different > compilers), I think the preferred form is plain `attribute'. i never said asm-powerpc/processor.h was exported to userspace ... i did say that i changed the file to be consistent with all other files. -mike
Attachment:
signature.asc
Description: This is a digitally signed message part.
- References:
- [patch] use __attribute__ in asm-powerpc
- From: Mike Frysinger <[email protected]>
- Re: [patch] use __attribute__ in asm-powerpc
- From: Geert Uytterhoeven <[email protected]>
- [patch] use __attribute__ in asm-powerpc
- Prev by Date: Re: [PATCH] slob: reduce list scanning
- Next by Date: Re: Hibernation considerations
- Previous by thread: Re: [patch] use __attribute__ in asm-powerpc
- Next by thread: [PATCH 0/5] Misc helper patches for pid namespaces
- Index(es):
 |