On Mon, Jul 16 2007, Geert Uytterhoeven wrote: > On Fri, 13 Jul 2007, Geert Uytterhoeven wrote: > > Ah, that explains it. flush_dcache_page() is used in some drivers. > > I'll update my patches. Thanks for the comments! > > Does this look OK? > - Replaced KM_USER0 by KM_IRQ0 (all routines are either called from an > interrupt handler, from .request_fn (ps3disk), or from .queuecommand > (ps3rom)) That looks good. > - Add a call to flush_kernel_dcache_page() in routines that write to buffers Hmm, I would have thought a flush_dcache_page() would be more appropriate, the backing could be page cache pages. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver
- From: James Bottomley <[email protected]>
- Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver
- From: Geert Uytterhoeven <[email protected]>
- Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver
- References:
- [patch 0/6] PS3 Storage Drivers for 2.6.23, take 4
- From: Geert Uytterhoeven <[email protected]>
- Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver
- From: Geert Uytterhoeven <[email protected]>
- Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver
- From: James Bottomley <[email protected]>
- Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver
- From: Arnd Bergmann <[email protected]>
- Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver
- From: Geert Uytterhoeven <[email protected]>
- Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver
- From: James Bottomley <[email protected]>
- Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver
- From: Geert Uytterhoeven <[email protected]>
- Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver
- From: Geert Uytterhoeven <[email protected]>
- [patch 0/6] PS3 Storage Drivers for 2.6.23, take 4
- Prev by Date: Re: [2.6 patch] more ACSI removal
- Next by Date: Re: Oops while modprobing phy fixed module
- Previous by thread: Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver
- Next by thread: Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver
- Index(es):
 |