On Sun, 15 Jul 2007, Latchesar Ionkov wrote:
I thought that it is not a good idea to keep the v9fs_ prefix for code
that is in different places (fs/9p and net/9p). If keeping the old
prefix is more acceptable, I can create a new patch without the
"v9fs_"->"p9_" renames.
do the code reorg and the name changes as two different patches. it makes
it much easier to see that the rename doesn't change any functionality,
and makes the code reorg much easier to see.
David Lang
Thanks,
Lucho
On 7/15/07, Linus Torvalds <[email protected]> wrote:
On Sat, 14 Jul 2007, Eric Van Hensbergen wrote:
>
> The bulk of the changes were in the reorganization patch which mostly
> moved files and interfaces around in preparation for work on an
> in-kernel 9p server.
Please use "git diff -C --stat --summary" to generate the diffstat
summary.
In particular, because you didn't use -C (or -M), git have you an
old-style diffstat without renames, so the diffstat doesn't show that a
lot of it was moving code around.
(That said, you seem to have changed names a lot too, so it's not pure
code movement).
> 49 files changed, 5400 insertions(+), 5092 deletions(-)
With rename detection enabled, I get
36 files changed, 3444 insertions(+), 3130 deletions(-)
due to finding some (partially dubious) renames:
rename fs/9p/mux.h => include/net/9p/conn.h (53%)
rename {fs => include/net}/9p/transport.h (59%)
rename {fs => net}/9p/conv.c (55%)
rename {fs => net}/9p/fcprint.c (64%)
rename {fs => net}/9p/mux.c (55%)
even though is misses a lot of others (due to all the "v9fs" -> "p9"
changes in the source code too - was that really worth it?).
Linus
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
V9fs-developer mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/v9fs-developer
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
