Re: [2.6 patch] drivers/mmc/core/: make 4 functions static

On Fri, 13 Jul 2007 01:56:02 +0200
Adrian Bunk <[email protected]> wrote:

> This patch makes the following needlessly global functions static:
> - sd_ops.c: mmc_wait_for_app_cmd()
> - core.c: mmc_start_request()

I am a bit torn about these two. Even though we don't cater to
out-of-tree stuff, having these as exported symbols shows that they are
part of the API. Removing them might risk people going about doing
something silly because they don't know the functionality exists, and
we might not spot it at patch review time.

Rgds
-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [2.6 patch] drivers/mmc/core/: make 4 functions static
  - From: Adrian Bunk <[email protected]>

References:
- [2.6 patch] drivers/mmc/core/: make 4 functions static
  - From: Adrian Bunk <[email protected]>

Prev by Date: Re: [RFC] Orphaning MMC host drivers
Next by Date: Re: Documentation of kernel messages (Summary)
Previous by thread: [2.6 patch] drivers/mmc/core/: make 4 functions static
Next by thread: Re: [2.6 patch] drivers/mmc/core/: make 4 functions static
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]