On Sun, 2007-07-15 at 11:36 +0200, Michael Buesch wrote:
> On Sunday 15 July 2007 11:16:56 Bryan Wu wrote:
> > In current Blackfin DMA allocation/free, the return value from
> > bfin_mac_alloc() is used as the dma_handle, here it is the
> > tx_desc/rx_desc.
> > The "dma_handle" is useless in the following code.
>
> I think a comment has to be added, at least, as it's very confusing.
No problem, it should be.
>
> > This is some magic code for PHY ID. In the future, we will rewrite some
> > code based on kernel phy abstraction layer to support more phy device.
>
> Ok, nice idea.
>
> > > Unwind the allocations above, if registering fails.
> > >
> >
> > In fact, it is safe. Because if registering fails, bf537mac_probe will
> > return none zero to bfin_mac_probe which will do free_netdev.
>
> Hm, weren't there some DMA allocations, too? Are they free'd properly?
>
Oh, the DMA allocation happens in bf537mac_open not in bf537mac_probe.
so when registering fails, only free_netdev should be ok.
I sent out a new driver patch for #2 try, please give us some comments
Thanks
- Bryan Wu
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
