Re: [PATCH 3/8] drivers edac new pasemi driver

[Andrew Morton <akpm@linux-foundation.org>]

On Sat, 14 Jul 2007 17:12:45 -0700 (PDT) Doug Thompson <norsk5@yahoo.com> wrote:

> 
> --- Andrew Morton <akpm@linux-foundation.org> wrote:
> 
> 
> > > +		default:
> > > +			edac_mc_printk(mci, KERN_ERR,
> > > +				       "Unrecognized Rank Config\n");
> > 
> > If this message ever comes out, you're gonna say "argh, I wish I'd printed
> > rankcfg".
> > 
> > Do you want to do this??
> 
> Yeah, I will gen a patch for him. He is in india and turn around takes a day or two
> 

Confused.  I already did the patch, below.  

> 
> 
> 
> > 
> > --- a/drivers/edac/pasemi_edac.c~drivers-edac-new-pasemi-driver-fix
> > +++ a/drivers/edac/pasemi_edac.c
> > @@ -168,7 +168,8 @@ static int pasemi_edac_init_csrows(struc
> >  			break;
> >  		default:
> >  			edac_mc_printk(mci, KERN_ERR,
> > -				       "Unrecognized Rank Config\n");
> > +				"Unrecognized Rank Config. rankcfg=%u\n",
> > +				rankcfg);
> >  			return -EINVAL;
> >  		}
> >  
> > @@ -244,9 +245,8 @@ static int __devinit pasemi_edac_probe(s
> >  	 */
> >  	pasemi_edac_get_error_info(mci);
> >  
> > -	if (edac_mc_add_mc(mci, system_mmc_id++)) {
> > +	if (edac_mc_add_mc(mci, system_mmc_id++))
> >  		goto fail;
> > -	}
> >  
> >  	/* get this far and it's successful */
> >  	return 0;
> > _
> > 
> > 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/