Re: [PATCH 1/3] Blackfin ethernet driver: on chip ethernet MAC controller driver

Michael Buesch wrote:

Well, this bitfield _might_ be OK (although I don't like bitfields
at all), but the above pointer casting stuff should really use
leXX_to_cpu. It's so easy to use and it is easier to read and
maintain the code afterwards.
If the bitfield stays, a comment must be added.

Regardless of endian issues, the bitfield usage should go away.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 1/3] Blackfin ethernet driver: on chip ethernet MAC controller driver
    • From: Bryan Wu <[email protected]>
  • Re: [PATCH 1/3] Blackfin ethernet driver: on chip ethernet MAC controller driver
    • From: Michael Buesch <[email protected]>
  • Re: [PATCH 1/3] Blackfin ethernet driver: on chip ethernet MAC controller driver
    • From: "Mike Frysinger" <[email protected]>
  • Re: [PATCH 1/3] Blackfin ethernet driver: on chip ethernet MAC controller driver
    • From: Michael Buesch <[email protected]>

• Prev by Date: Re: [RFC] Thread Migration Preemption - v4
• Next by Date: Re: [PATCH 0/3][try 1] init: enable system-on-initramfs
• Previous by thread: Re: [PATCH 1/3] Blackfin ethernet driver: on chip ethernet MAC controller driver
• Next by thread: Re: [PATCH 1/3] Blackfin ethernet driver: on chip ethernet MAC controller driver
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]