Re: [PATCH] generic_nvram: use inode lock not lock_kernel

> Can we just use generic_file_llseek() in here?  afacit that simply requires
> that i_size have the correct value.  Does it?

Yes.

> Generic_file_llseek() uses file->f_mapping->host->i_mutex which is
> equivalent for this file, but we might as well be consistent.

Last time I used file->f_mapping->host-> for this in another driver Al
Viro asked me to use the f_path sequence instead. So I've always done
that since.

If it is correct to use the other then generic_file_llseek looks fine, if
not perhaps we need generic_device_llseek() ?

Al - there are many clones of these lseek methods - which should we be
using ?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] generic_nvram: use inode lock not lock_kernel
    • From: Alan Cox <[email protected]>
  • Re: [PATCH] generic_nvram: use inode lock not lock_kernel
    • From: Andrew Morton <[email protected]>

• Prev by Date: [PATCH] X86_64: hpet tsc calibration fix broken smi detection logic
• Next by Date: Re: [PATCH 2/3] libata: use ->proto_mask in drivers
• Previous by thread: Re: [PATCH] generic_nvram: use inode lock not lock_kernel
• Next by thread: [PATCH] mbcs: Remove lots of global symbols
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]