Re: Always zero test in arch/i386/pci/mmconfig-shared.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Robert Hancock wrote:
 > You missed this code:

name = pci_mmcfg_probes[i].probe();

This calls one of the probe functions above, which will set pci_mmcfg_config_num to something else, as with the name variable. It may set the name but not the config num, if the chipset is recognized but MMCONFIG isn't enabled, etc.

Obvious now you've pointed it out. Bit of of a weird way to do things.
I might brew up a patch which adds the names to the pci_mmcfg_hostbridge_probe struct, since they appear to be always returned if the probe function is called, and make the probe functions return the config num.

Cheers,
Scott
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux