Re: [EXT4 set 7][PATCH 1/1]Remove 32000 subdirs limit.

On 7/13/07, Kalpak Shah <[email protected]> wrote:

> EXT4_DIR_LINK_MAX() is buggy: it evaluates its arg twice.

#define EXT4_DIR_LINK_MAX(dir) (!is_dx(dir) && (dir)->i_nlink >= EXT4_LINK_MAX)

[snip]

Sorry, I didn't understand what is the problem with this macro?

The expression represented by 'dir' is evaluated twice (think dir++
here). It's safer to make it a static inline function.

                                      Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [EXT4 set 7][PATCH 1/1]Remove 32000 subdirs limit.
    • From: Mingming Cao <[email protected]>
  • Re: [EXT4 set 7][PATCH 1/1]Remove 32000 subdirs limit.
    • From: Andrew Morton <[email protected]>
  • Re: [EXT4 set 7][PATCH 1/1]Remove 32000 subdirs limit.
    • From: Kalpak Shah <[email protected]>

• Prev by Date: Re: [PATCH][RFC] network splice receive v3
• Next by Date: PS3 Storage Driver O_DIRECT issue
• Previous by thread: Re: [EXT4 set 7][PATCH 1/1]Remove 32000 subdirs limit.
• Next by thread: Re: [EXT4 set 7][PATCH 1/1]Remove 32000 subdirs limit.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]