Re: [Resend][Patch] drivers/mtd/maps/tqm8xxl.c: Do some cleanups

On Fri, 2007-07-13 at 11:48 +0800, WANG Cong wrote:
>                 if(map_banks[idx] == NULL) {
>                         ret = -ENOMEM;
> -                       /* FIXME: What if some MTD devices were probed already? */
> +                       /* FIXME: What if some MTD devices were probed
> +                       already? */
>                         goto error_mem;
>                 } 


That's just horrid. Leave it as it was.

-- 
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [Resend][Patch] drivers/mtd/maps/tqm8xxl.c: Do some cleanups
    • From: WANG Cong <[email protected]>

• References:
  • [Patch] drivers/mtd/maps/tqm8xxl.c: Style cleanups
    • From: WANG Cong <[email protected]>
  • Re: [Patch] drivers/mtd/maps/tqm8xxl.c: Style cleanups
    • From: Josh Boyer <[email protected]>
  • [Resend][Patch] drivers/mtd/maps/tqm8xxl.c: Do some cleanups
    • From: WANG Cong <[email protected]>

• Prev by Date: Re: [PATCH 012 of 20] knfsd: nfsd4: make readonly access depend on pseudoflavor
• Next by Date: Re: [PATCH] Make asm-generic/ioctl.h more generic using conditionals.
• Previous by thread: [Resend][Patch] drivers/mtd/maps/tqm8xxl.c: Do some cleanups
• Next by thread: Re: [Resend][Patch] drivers/mtd/maps/tqm8xxl.c: Do some cleanups
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]