On Fri, Jul 13, 2007 at 01:10:46AM -0500, Kumar Gala wrote:
> On Thu, 12 Jul 2007, Greg KH wrote:
>
> > On Fri, Jul 13, 2007 at 12:55:39AM -0500, Kumar Gala wrote:
> > >
> > > On Jul 13, 2007, at 12:33 AM, Greg KH wrote:
> > >
> > > > On Fri, Jul 13, 2007 at 12:16:29AM -0500, Kumar Gala wrote:
> > > >> pci_do_scan_bus() and pci_bus_find_capability() are marked EXPORT_SYMBOL
> > > >> and thus usable outside of the PCI drive core itself. Make the prototypes
> > > >> for these functions accessible to everyone.
> > > >
> > > > Well, no, I'd like to only have the pci hotplug drivers use them if
> > > > possible. So until we have proper namespaces on the exported symbols,
> > > > I'd really like to keep these as-is if possible.
> > > >
> > > > Or are you needing these symbols for some code outside of the
> > > > drivers/pci/ directory tree?
> > >
> > > I need pci_bus_find_capability() in arch/powerpc pci code.
> > >
> > > I'm using it as a way to tell if we are a PCIe PHB.
> >
> > Ok, care to export only that function then?
>
> that's fine, will do.
>
> I assume we want to kill the prototype pci_bus_alloc_resource() in
> drivers/pci/pci.h since its duplicated in include/linux/pci.h
Yes.
> Also, I wasn't sure 'extern int pci_bus_find_capability'.. or just 'int
> pci_bus_find_capability'?
Whatever matches the surrounding code, I don't have a preference but I
think others might.
thanks,
greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
