Re: [RFT][PATCH v7] sata_mv: convert to new EH

[Jeff Garzik <jeff@garzik.org>]

dean gaudet wrote:
> On Wed, 11 Jul 2007, Jeff Garzik wrote:
>
> > As before, this patch is against 2.6.22 with no other patches needed nor
> > applied.
> >
> > In this revision, interrupt handling was improved quite a bit,
> > particularly for EDMA.  The WARNING in mv_get_crpb_status() goes away,
> > because that routine went away.  Its EDMA handling was potentially racy
> > as well.  It was replaced with a loop in mv_intr_edma() that guarantees
> > it always clears responses out of the queue, not a single response.
> >
> > Here's hoping that the WARNING in mv_qc_issue() goes away as well, but I
> > am less than 50% confident that will happen.
> >
> > The driver is making substantial progress with all these improvements,
> > though, in searching for the cause of this hardware behavior :)
> >
> > Though if mv_qc_issue() still warns, I would be interested to know if
> > this driver works OK if the mv_qc_issue() warning is simply removed at
> > that point...
>
> oh very nice... no warnings on boot, and no warnings while i "dd 
> if=/dev/sdX of=/dev/null" and i'm seeing 74MB/s+ from each disk on this 
> simple read test.
>
> for lack of a better test i started an untar/diff stress test on the 
> disks... we'll see how it goes.  (it's based on doug ledford's 
> memtest.sh)

Thanks for the testing.  Looks like we might have hit on something good...

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/