Re: [PATCH 24/61] sysfs: make sysfs_put() ignore NULL sd

On Thu, Jul 12, 2007 at 08:50:47AM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@ wrote:
> In article <[email protected]> (at Wed, 11 Jul 2007 16:31:43 -0700), Greg Kroah-Hartman <[email protected]> says:
> 
> > Make sysfs_put() ignore NULL sd instead of oopsing.
> 
> I do not think this is a good idea; it is non-sense (and rather a bug)
> to call "put" with NULL argument in general.

It's better than having to check it all the time in the caller :)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 24/61] sysfs: make sysfs_put() ignore NULL sd
    • From: YOSHIFUJI Hideaki / 吉藤英明 <[email protected]>

• References:
  • [PATCH 22/61] sysfs: move release_sysfs_dirent() to dir.c
    • From: Greg Kroah-Hartman <[email protected]>
  • [PATCH 23/61] sysfs: allocate inode number using ida
    • From: Greg Kroah-Hartman <[email protected]>
  • [PATCH 24/61] sysfs: make sysfs_put() ignore NULL sd
    • From: Greg Kroah-Hartman <[email protected]>
  • Re: [PATCH 24/61] sysfs: make sysfs_put() ignore NULL sd
    • From: YOSHIFUJI Hideaki / 吉藤英明 <[email protected]>

• Prev by Date: Re: [PATCH] Pass -g to assembler under CONFIG_DEBUG_INFO
• Next by Date: Re: Linux 2.6.22 released
• Previous by thread: Re: [PATCH 24/61] sysfs: make sysfs_put() ignore NULL sd
• Next by thread: Re: [PATCH 24/61] sysfs: make sysfs_put() ignore NULL sd
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]