Re: [PATCH] UBI: cleanup usage of try_module_get

On Wed, 2007-07-11 at 17:11 +0900, Fernando Luis Vázquez Cao wrote:
> The use of try_module_get(THIS_MODULE) in ubi_get_device_info does not
> offer real protection against unexpected driver unloads, since we could
> be preempted before try_modules_get gets executed. It is the caller who
> should manipulate the refcounts. Besides, ubi_get_device_info is an
> exported symbol which guarantees protection when accessed through
> symbol_get.

Yeah, looks fair, committed to UBI git, thanks.

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH RFC] try_module_get usage
    • From: Fernando Luis Vázquez Cao <[email protected]>
  • [PATCH] UBI: cleanup usage of try_module_get
    • From: Fernando Luis Vázquez Cao <[email protected]>

• Prev by Date: Re: [PATCH] LinuxPPS (with new syscalls API) - new version
• Next by Date: [PATCH][RFC] network splice receive v3
• Previous by thread: [PATCH] UBI: cleanup usage of try_module_get
• Next by thread: Re: [PATCH RFC] try_module_get usage
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]