Re: [EXT4 set 6][PATCH 1/1]Export jbd stats through procfs

2007/7/10, Andrew Morton <[email protected]>:

Hi all,

> +     size = sizeof(struct transaction_stats_s);
> +     s->stats = kmalloc(size, GFP_KERNEL);
> +     if (s == NULL) {
> +             kfree(s);
> +             return -EIO;

ENOMEM

I'm sorry if i missed some point, but i just don't see the use of such
a kfree here, not sure Andrew meant you should only return ENOMEM
instead, but why issuing those kfree(NULL), instead of just a if (!s)
return ENOMEM ?

Regards,
Cédric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [EXT4 set 6][PATCH 1/1]Export jbd stats through procfs
    • From: Andrew Morton <[email protected]>
  • Re: [EXT4 set 6][PATCH 1/1]Export jbd stats through procfs
    • From: Alexey Dobriyan <[email protected]>

• References:
  • [EXT4 set 6][PATCH 1/1]Export jbd stats through procfs
    • From: Mingming Cao <[email protected]>
  • Re: [EXT4 set 6][PATCH 1/1]Export jbd stats through procfs
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: [EXT4 set 4][PATCH 1/5] i_version:64 bit inode version
• Next by Date: Re: [EXT4 set 4][PATCH 1/5] i_version:64 bit inode version
• Previous by thread: Re: [EXT4 set 6][PATCH 1/1]Export jbd stats through procfs
• Next by thread: Re: [EXT4 set 6][PATCH 1/1]Export jbd stats through procfs
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]