Jan Engelhardt wrote:
> On Jul 9 2007 19:51, H. Peter Anvin wrote:
>> +
>> +static inline int isdigit(int ch)
>> +{
>> + return (ch >= '0') && (ch <= '9');
>> +}
>
> I'd say static inline unsigned int isdigit(unsigned char), since ASCII does not
> realistically exceed 255.
If you're trying to be standard, you're doing the wrong thing (the
standard is int, since -1 is a permitted value.)
It doesn't matter anyway, and your version would probably generate
slightly worse code.
>> +static int strnlen(const char *s, int maxlen)
>
> unsigned int, and unsigned int, too?
> The glibc strnlen type also uses unsigned types.
If anything it should be size_t. Fixing, and moved to string.c, where
it belongs.
-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- References:
- x86 setup code rewrite in C
- From: "H. Peter Anvin" <[email protected]>
- [x86 setup 02/33] hd.c: remove BIOS/CMOS queries
- From: "H. Peter Anvin" <[email protected]>
- [x86 setup 03/33] include/asm-i386/boot.h: This is <asm/boot.h>, not <linux/boot.h>
- From: "H. Peter Anvin" <[email protected]>
- [x86 setup 04/33] Unify the CPU features vectors between i386 and x86-64
- From: "H. Peter Anvin" <[email protected]>
- [x86 setup 05/33] Change CONFIG_X86_MINIMUM_CPU_MODEL to CONFIG_X86_MINIMUM_CPU_FAMILY
- From: "H. Peter Anvin" <[email protected]>
- [x86 setup 06/33] Clean up struct screen_info (<linux/screen_info.h>)
- From: "H. Peter Anvin" <[email protected]>
- [x86 setup 07/33] Use a new CPU feature word to cover all Intel features that are spread around
- From: "H. Peter Anvin" <[email protected]>
- [x86 setup 08/33] Define zero-page offset 0x1e4 as a scratch field, and use it
- From: "H. Peter Anvin" <[email protected]>
- [x86 setup 09/33] Make definitions for struct e820entry and struct e820map consistent
- From: "H. Peter Anvin" <[email protected]>
- [x86 setup 10/33] Make struct boot_params a real structure, and remove obsolete fields
- From: "H. Peter Anvin" <[email protected]>
- [x86 setup 11/33] x86-64: add CONFIG_PHYSICAL_ALIGN for consistency with i386
- From: "H. Peter Anvin" <[email protected]>
- [x86 setup 12/33] x86-64: add symbolic constants for the boot segment selectors
- From: "H. Peter Anvin" <[email protected]>
- [x86 setup 13/33] Header file to produce 16-bit code with gcc
- From: "H. Peter Anvin" <[email protected]>
- [x86 setup 14/33] Top header file for new x86 setup code
- From: "H. Peter Anvin" <[email protected]>
- [x86 setup 15/33] Simple bitops for the new x86 setup code.
- From: "H. Peter Anvin" <[email protected]>
- [x86 setup 16/33] String-handling functions for the new x86 setup code.
- From: "H. Peter Anvin" <[email protected]>
- [x86 setup 17/33] A20 handling code
- From: "H. Peter Anvin" <[email protected]>
- [x86 setup 18/33] APM probing code
- From: "H. Peter Anvin" <[email protected]>
- [x86 setup 19/33] Command-line parsing code for the new x86 setup code
- From: "H. Peter Anvin" <[email protected]>
- [x86 setup 20/33] Console-writing code for the new x86 setup code
- From: "H. Peter Anvin" <[email protected]>
- Re: [x86 setup 20/33] Console-writing code for the new x86 setup code
- From: Jan Engelhardt <[email protected]>
- x86 setup code rewrite in C
- Prev by Date: Re: [PATCH re-resend] fix race in AF_UNIX garbage collector
- Next by Date: Re: [PATCH 1/2] [ide] mmio ide support
- Previous by thread: Re: [x86 setup 20/33] Console-writing code for the new x86 setup code
- Next by thread: Re: [x86 setup 17/33] A20 handling code
- Index(es):
 |