Re: 2.6.22-rc6(mm1) Unable to handle kernel NULL pointer dereference - git-bisect result

On Sun, 8 Jul 2007, Ulrich Drepper wrote:
> 
> But the real permissions tests are performed in notify_change.  I think
> all this is consistent with how, for instance, fchmod works.  The
> additional tests in fchmod which aren't here (IS_RDONLY and IS_APPEND)
> would also apply to the case where a file name is given.  So, either the
> code was inconsistent already are these tests are really not needed.

No.

notify_change() does *not* do permission checks for 
ATTR_CTIME/MTIME/ATIME.

It does them for the "xxx_SET" attributes, but MTIME/ATIME is expected to 
change when other things change, so notify_change() expects that those 
_other_ changes have been validated from a security standpoint!

utimes() is special.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: 2.6.22-rc6(mm1) Unable to handle kernel NULL pointer dereference - git-bisect result
    • From: Linus Torvalds <[email protected]>
  • Re: 2.6.22-rc6(mm1) Unable to handle kernel NULL pointer dereference - git-bisect result
    • From: Ulrich Drepper <[email protected]>

• References:
  • 2.6.22-rc6-mm1-cfs-v19 Unable to handle kernel NULL pointer dereference (reproducable)
    • From: Markus Trippelsdorf <[email protected]>
  • Re: 2.6.22-rc6-mm1-cfs-v19 Unable to handle kernel NULL pointer dereference (reproducable)
    • From: Andrew Morton <[email protected]>
  • Re: 2.6.22-rc6-mm1-cfs-v19 Unable to handle kernel NULL pointer dereference (reproducable)
    • From: Markus Trippelsdorf <[email protected]>
  • Re: 2.6.22-rc6(mm1) Unable to handle kernel NULL pointer dereference - git-bisect result
    • From: Markus Trippelsdorf <[email protected]>
  • Re: 2.6.22-rc6(mm1) Unable to handle kernel NULL pointer dereference - git-bisect result
    • From: Ulrich Drepper <[email protected]>
  • Re: 2.6.22-rc6(mm1) Unable to handle kernel NULL pointer dereference - git-bisect result
    • From: Al Viro <[email protected]>
  • Re: 2.6.22-rc6(mm1) Unable to handle kernel NULL pointer dereference - git-bisect result
    • From: Ulrich Drepper <[email protected]>

• Prev by Date: Re: [PATCH] Remove process freezer from suspend to RAM pathway
• Next by Date: Re: [PATCH] retrieve VBE EDID/DDC info independent of used video mode
• Previous by thread: Re: 2.6.22-rc6(mm1) Unable to handle kernel NULL pointer dereference - git-bisect result
• Next by thread: Re: 2.6.22-rc6(mm1) Unable to handle kernel NULL pointer dereference - git-bisect result
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]