Re: [PATCH 09/20] KVM: MMU: Fix Wrong tlb flush order

Ingo Molnar wrote:

* Avi Kivity <[email protected]> wrote:

From: Shaohua Li <[email protected]>

Need to flush the tlb after updating a pte, not before.

 		rmap_remove(vcpu, spte);
-		kvm_flush_remote_tlbs(vcpu->kvm);
 		set_shadow_pte(spte, *spte & ~PT_WRITABLE_MASK);
+		kvm_flush_remote_tlbs(vcpu->kvm);

hm, isnt this a must-have fix for v2.6.22 (and .21) as well?

Guest SMP support is only enabled by another patch in this patchset.


--
error compiling committee.c: too many arguments to function

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 00/20] KVM updates for 2.6.23, part 2
    • From: Avi Kivity <[email protected]>
  • [PATCH 09/20] KVM: MMU: Fix Wrong tlb flush order
    • From: Avi Kivity <[email protected]>
  • Re: [PATCH 09/20] KVM: MMU: Fix Wrong tlb flush order
    • From: Ingo Molnar <[email protected]>

• Prev by Date: Re: malicious filesystems (was Re: [linux-pm] Re: [PATCH] Remove process freezer from suspend to RAM pathway)
• Next by Date: Re: PROBLEM: MacBook makes whining noise when usb-uhci active
• Previous by thread: Re: [PATCH 09/20] KVM: MMU: Fix Wrong tlb flush order
• Next by thread: [PATCH 17/20] SMP: Implement on_cpu()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]