Hi Satyam,
The following comments aren't essential.
> if (!(event == NETDEV_UP || event == NETDEV_DOWN ||
> event == NETDEV_CHANGEADDR || event == NETDEV_CHANGENAME))
> - goto done;
> + goto done;
The above diff lines are extra.
> + spin_lock_irqsave(&target_list_lock, flags);
> + list_for_each_entry(nt, &target_list, list) {
> + if (nt->np.dev == dev) {
> + switch (event) {
> + case NETDEV_UP:
> + case NETDEV_DOWN:
> + nt->dev_status = net_dev_is_up(nt->np.dev);
> + break;
> +
> + case NETDEV_CHANGEADDR:
> + memcpy(nt->np.local_mac, dev->dev_addr, ETH_ALEN);
The above line is over 80 characters.
Thanks,
--
Keiichi KII
NEC Corporation OSS Platform Development Division
E-mail: [email protected]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
