Re: [2.6 patch] mm/vmstat.c: possible cleanups

On Fri, Jul 06, 2007 at 10:49:02AM -0700, Christoph Lameter wrote:
> On Fri, 6 Jul 2007, Adrian Bunk wrote:
> 
> > This patch contains the following possible cleanups:
> > - make the needlessly global setup_vmstat() static
> 
> Ok.
> 
> > - #if 0 the unused refresh_vm_stats()
> 
> Hmmm... This may be needed by the cpu idle code to update the vm stats 
> before going idle.

Since 1 year it's making the kernel image larger without having a single 
user.

And if it will one day get a user, removing the #if 0 will be trivial.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [2.6 patch] mm/vmstat.c: possible cleanups
    • From: Christoph Lameter <[email protected]>

• References:
  • [2.6 patch] mm/vmstat.c: possible cleanups
    • From: Adrian Bunk <[email protected]>
  • Re: [2.6 patch] mm/vmstat.c: possible cleanups
    • From: Christoph Lameter <[email protected]>

• Prev by Date: Re: [PATCH] memory unplug v7 [2/6] - isolate_lru_page fix
• Next by Date: preemption counter havoc on kgdb-taken faults (was: kgdb Bad IO access)
• Previous by thread: Re: [2.6 patch] mm/vmstat.c: possible cleanups
• Next by thread: Re: [2.6 patch] mm/vmstat.c: possible cleanups
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]