[PATCH] mm: double mark_page_accessed() in read_cache_page_async()

read_cache_page_async() seems to have two invocations of
mark_page_accessed() which will launch pages right onto the active list.

Remove the first one, keeping the latter one. This avoids marking
unwanted pages active (in the retry loop).

Signed-off-by: Peter Zijlstra <[email protected]>
---
 mm/filemap.c |    1 -
 1 file changed, 1 deletion(-)

Index: linux-2.6/mm/filemap.c
===================================================================
--- linux-2.6.orig/mm/filemap.c
+++ linux-2.6/mm/filemap.c
@@ -1588,7 +1588,6 @@ retry:
 	page = __read_cache_page(mapping, index, filler, data);
 	if (IS_ERR(page))
 		return page;
-	mark_page_accessed(page);
 	if (PageUptodate(page))
 		goto out;
 


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] mm: double mark_page_accessed() in read_cache_page_async()
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: [PATCH] USB: Remove Makefile reference to obsolete OHCI_AT91.
• Next by Date: Re: dead(?) i386-related CONFIG variables
• Previous by thread: Write-only stuff in CFQ data structures
• Next by thread: Re: [PATCH] mm: double mark_page_accessed() in read_cache_page_async()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]