Re: [PATCH] dio: remove bogus refcounting BUG_ON

the BUG_ON(). But unfortunately, our perf. team is able reproduce the
problem.

What are they doing to reproduce it?  How much setup does it take?

Debug indicated that, the ret2 == 1 :(

That could be consistent with the theory that we're racing with the dio struct being freed and reused before it's tested in the BUG_ON() condition. Suparna's suggestion to sample dio->is_async before releasing the refcount and using that in the BUG_ON condition is a good one.

- z
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] dio: remove bogus refcounting BUG_ON
    • From: Badari Pulavarty <[email protected]>

• References:
  • [PATCH] dio: remove bogus refcounting BUG_ON
    • From: Zach Brown <[email protected]>
  • Re: [PATCH] dio: remove bogus refcounting BUG_ON
    • From: Badari Pulavarty <[email protected]>

• Prev by Date: Re: [RFC] bloody mess with __attribute__() syntax
• Next by Date: Re: [PATCH 1/4] Sky Cpu and Nexus: code style improvement
• Previous by thread: Re: [PATCH] dio: remove bogus refcounting BUG_ON
• Next by thread: Re: [PATCH] dio: remove bogus refcounting BUG_ON
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]